Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimization suggestions: Add debounce ability to trigger search function #8

Open
suziwen opened this issue Apr 15, 2020 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@suziwen
Copy link
Contributor

suziwen commented Apr 15, 2020

Just like using this function https://underscorejs.org/#debounce

And also can add a options minChar. when the search string is too short, the search function will not be triggered.

@TheJaredWilcurt TheJaredWilcurt added enhancement New feature or request good first issue Good for newcomers labels Apr 16, 2020
@TheJaredWilcurt
Copy link
Member

Tried to do a simple debounce on this, but it causes a race condition, where you can get out-of-order results. The branch is up as a PR, but the feature won't be merged until that is addressed.

@TheJaredWilcurt TheJaredWilcurt added help wanted Extra attention is needed and removed good first issue Good for newcomers labels Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants