Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nw-builder always redownloads nw.js binaries #1037

Closed
1 task done
CosmoMyzrailGorynych opened this issue Feb 18, 2024 · 2 comments
Closed
1 task done

nw-builder always redownloads nw.js binaries #1037

CosmoMyzrailGorynych opened this issue Feb 18, 2024 · 2 comments

Comments

@CosmoMyzrailGorynych
Copy link
Contributor

Issue Type

  • Bug Report

Current/Missing Behaviour

The most basic run of the builder always redownloads nw.js ignoring its own cache, which causes slow startups (5+ mins). The redownloads can be observed by node.js network activity + file update changes on cached zip files.

builder = nwbuild({
  mode: "run",
  srcDir: "./",
  version: '0.84.0',
  glob: false,
});

Expected/Proposed Behaviour

nw-builder must not redownload nw.js if it is already present in its cache directory.

Additional Info

  • Package version: v4.6.0
  • Operating System: Windows
  • Node version: v20.7.0
  • NW.js version: 0.84.0/0.83.0
  • Repro link: see the issue
@ayushmanchhabra
Copy link
Collaborator

@CosmoMyzrailGorynych please try v4.6.1

@CosmoMyzrailGorynych
Copy link
Contributor Author

Confirming that the issue is fixed in v4.6.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants