Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1042

Merged
merged 12 commits into from
Feb 22, 2024
Merged

Fixes #1042

merged 12 commits into from
Feb 22, 2024

Conversation

zkrige
Copy link
Collaborator

@zkrige zkrige commented Feb 22, 2024

FFMpeg copy path was not correct

zkrige and others added 12 commits February 21, 2024 14:29
- fix macos symlinks
- fix ffmpeg download
Co-authored-by: Ayushman Chhabra <14110965+ayushmanchhabra@users.noreply.github.com>
Co-authored-by: Ayushman Chhabra <14110965+ayushmanchhabra@users.noreply.github.com>
Co-authored-by: Ayushman Chhabra <14110965+ayushmanchhabra@users.noreply.github.com>
Co-authored-by: Ayushman Chhabra <14110965+ayushmanchhabra@users.noreply.github.com>
Co-authored-by: Ayushman Chhabra <14110965+ayushmanchhabra@users.noreply.github.com>
Co-authored-by: Ayushman Chhabra <14110965+ayushmanchhabra@users.noreply.github.com>
Co-authored-by: Ayushman Chhabra <14110965+ayushmanchhabra@users.noreply.github.com>
Co-authored-by: Ayushman Chhabra <14110965+ayushmanchhabra@users.noreply.github.com>
* main:
  chore(main): release 4.6.2 (#1039)
  fix(get): ffmpeg and symlinks
@zkrige zkrige merged commit 2c29e90 into main Feb 22, 2024
3 checks passed
@zkrige zkrige deleted the fixes branch February 22, 2024 14:03
@zkrige
Copy link
Collaborator Author

zkrige commented Feb 22, 2024

@ayushmanchhabra I squash merged this but the actions didnt build a new version 😬

@ayushmanchhabra
Copy link
Collaborator

ayushmanchhabra commented Feb 22, 2024

Here are the guidelines to follow:
https://github.com/nwutils/nw-builder#contributing

Essentially, the PR title is used as commit header and description as commit body. The Release please action parses fix, feat and chore commit messages only:

For eg:

fix(get): lorem ipsum

* describe change not covered commit message above
* describe another change

@ayushmanchhabra
Copy link
Collaborator

ayushmanchhabra commented Feb 22, 2024

Could you maybe revert this and make a new PR? I'll try amending the commit message

ayushmanchhabra pushed a commit that referenced this pull request Feb 22, 2024
ayushmanchhabra pushed a commit that referenced this pull request Feb 22, 2024
🤖 I have created a release *beep* *boop*
---


##
[4.6.3](v4.6.2...v4.6.3)
(2024-02-22)


### Bug Fixes

* **get:** correct ffmpeg path
([#1042](#1042))
([391a6e1](391a6e1))


### Chores

* **docs:** update contributing guidelines
([ca594df](ca594df))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants