Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC #623

Closed
ayushmanchhabra opened this issue Aug 14, 2022 · 7 comments
Closed

RFC #623

ayushmanchhabra opened this issue Aug 14, 2022 · 7 comments
Assignees

Comments

@ayushmanchhabra
Copy link
Collaborator

ayushmanchhabra commented Aug 14, 2022

API v4

nwbuild install --version=0.67.0 --flavour=sdk --outDir

Install one or more NW.js binaries.

nwbuild develop --manifestFile=./nw.develop.json

nwbuild automatically looks for the nw.develop.json manifest which defines options which are more suited for development.

nwbuild package --manifestFile=./nw.package.json

nwbuild automatically looks for the nw.package.json manifest which defines options which are more suited for packaging.

nwbuild installer --extention=dmg

An installer for the packaged applications.

@sysrage
Copy link
Contributor

sysrage commented Aug 14, 2022

IMO, all of this would be nice but none of it should be part of nw-builder. Instead, start a project like the Vue CLI tools -- nwcli or something similar, which has the listed functionality.

@TheJaredWilcurt
Copy link
Member

I agree with @sysrage, separating CLI and docker stuff makes sense to me. It lets their repo(s) be more scoped to the specific problem it is trying to solve. And it keeps the nw-builder more focused and allows it to evolve to handle more edge cases needed by the community.

nw-builder should be focused on running locally on the current platform. Then if you want to set up GitHub Actions to run against Win, Lin, and OSX, and do 1 native build on each, that can work. Or if you want to just run your code on a single box using docker for the native builds, you could do that instead. But inside the docker container it would still just be using nw-builder normally.

But in general I like the idea of having some tooling that simplifies the process of using Docker and building each platform in their native environment, with their correct Node versions. That solves a lot of problems.

@ayushmanchhabra
Copy link
Collaborator Author

I knew what I wanted to build but didn't know if I should add it to a pre-existing tool like nw-builder or build one from scratch. This clears things up, thanks!

@ayushmanchhabra
Copy link
Collaborator Author

Working on it here:
https://github.com/ayushmxn/nwbuild

@sysrage
Copy link
Contributor

sysrage commented Aug 15, 2022

Working on it here: https://github.com/ayushmxn/nwbuild

Awesome! Might I suggest a name change, since many/most of the features aren't actually related to a "build" process? 😉

@ayushmanchhabra
Copy link
Collaborator Author

Sure! I made this a while ago and wasn't sure of it's purpose.

@ayushmanchhabra
Copy link
Collaborator Author

ayushmanchhabra commented Aug 15, 2022

Motivation for this was due to https://github.com/electron-userland/electron-builder and https://github.com/electron-userland/electron-forge. Essentially an all in one build tool but for NW.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants