Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

argv is not properly handled #945

Closed
1 of 3 tasks
zkrige opened this issue Sep 5, 2023 · 0 comments · Fixed by #946
Closed
1 of 3 tasks

argv is not properly handled #945

zkrige opened this issue Sep 5, 2023 · 0 comments · Fixed by #946

Comments

@zkrige
Copy link
Collaborator

zkrige commented Sep 5, 2023

Issue Type

  • Bug Report
  • Feature Request
  • Other

Current/Missing Behaviour

const nwProcess = spawn(
        resolve(nwDir, EXE_NAME[platform]),
        [srcDir.concat(argv)],
        {
          detached: true,
          windowsHide: true,
        },
      );

Expected/Proposed Behaviour

const nwProcess = spawn(
        resolve(nwDir, EXE_NAME[platform]),
        [...[srcDir], ...argv],
        {
          detached: true,
          windowsHide: true,
        },
      );

Additional Info

the existing code just concats argv params onto the srcdir which results in one long string parameter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant