Go test only checks main_test.go

[fallion]

nx-go/packages/nx-go/src/builders/test/builder.ts

Line 11 in d6fe943

const sources = `-v ${root}/**/*.go`

Uses go test /apps/name/**/*.go However this seems to only check the main_test.go. Perhaps apps/name/... might work better.

I can help if needed.

[Narven]

I think this needs to change from this:

export function runBuilder(options: BuildBuilderSchema, context: BuilderContext): Observable<BuilderOutput> {
  return from(context.getProjectMetadata(context?.target?.project)).pipe(
    map((project) => {
      const root = project.root
      const sources = `-v ${root}/**/*.go`

      return runGoCommand(context, 'test', [sources])
    }),
  )
}

to this:

export function runBuilder(options: BuildBuilderSchema, context: BuilderContext): Observable<BuilderOutput> {
  return from(context.getProjectMetadata(context?.target?.project)).pipe(
    map((project) => {
       const sources = `./... -v`; // also could include -race by default
        return runGoCommand(context, 'test', [sources], { cwd: project.root});
    }),
  )
}

[Narven]

The best approach it think, it would be to allow any extra arg be passed, that would allowd to had for example -race or -cover

[Narven]

@beeman let me know if you want me to PR on this

[Narven]

Also forgot about this, in the workspace.json it the builder needs to change from:

"test": {
  "builder": "@nx-go/nx-go:test",
  "options": {
    "main": "apps/api/main_test.go"
  }
}

to just:

"test": {
  "builder": "@nx-go/nx-go:test"
}

[beeman]

@beeman let me know if you want me to PR on this

Hey @Narven - I would really appreciate a PR! I should have some time this weekend en next weekend to look at nx-go!

I'm about to start a pet project that uses Go so I'll be using this again!

[Narven]

@beeman I do not have permissions to push a new branch

[fallion]

@Narven you can create a Pr by forking this repo and creating a branch on your fork. Then you should be able to open a PR here.

[beeman]

This is now fixed in version 1.3.0

[beeman]

The best approach it think, it would be to allow any extra arg be passed, that would allowd to had for example -race or -cover

Thanks for the suggestion! These are available and enabled by default in 1.4.0.