Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inotify_tracker logs fatal message without including error #53

Open
ehenoma opened this issue Dec 28, 2022 · 0 comments
Open

inotify_tracker logs fatal message without including error #53

ehenoma opened this issue Dec 28, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@ehenoma
Copy link

ehenoma commented Dec 28, 2022

I am using this library in production for years now and recently gotten in to more and more scenarios
in which apps are crashing because watchers can not be created.

Describe the bug
When a watcher can not be created the application crashes

watcher, err := fsnotify.NewWatcher()
if err != nil {
  util.Fatal("failed to create Watcher")
}

util.Fatal("failed to create Watcher")

Expected behaviour
I either expect this operation to return the error value or at least for the error to be included in the fatal log message

To Reproduce
You would have to create a system state in which fsnotify.NewWatcher() returns an error.
I can't point out the error that caused it in my case, since it is not logged by the library.
This error occurs rarely in some of my containers, the majority work as expected.

System information

  • tail version: latest
  • OS: alpine in Docker
  • Arch: amd64
@ehenoma ehenoma added the bug Something isn't working label Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant