Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playwright: remove playwright.base.config.ts from workspace root #48

Closed
1 task done
sebastiandg7 opened this issue Jan 23, 2023 · 0 comments · Fixed by #52
Closed
1 task done

Playwright: remove playwright.base.config.ts from workspace root #48

sebastiandg7 opened this issue Jan 23, 2023 · 0 comments · Fixed by #52
Assignees
Labels
bug Something isn't working scope:playwright @nxkit/playwright plugin related issues

Comments

@sebastiandg7
Copy link
Member

Current Behavior

The generated base config (meant to be shared across different playwright projects) do not have a specific tsconfig. Making this to fail for IDE linters as the node typings are not configured for that file.

Expected Behaviour

We can just have separate configurations and each user can opt to create a shared @nrwl/node lib exporting a base Playwright configuration.

Github Repo

No response

Steps to Reproduce

  1. pnpm nx g @nxkit/playwright:proj my-app-e2e
  2. Open the ./playwright.config.base.ts file in an IDE like vscode.

Nx Report

pnpm nx report                                                 

 >  NX   Report complete - copy this into the issue template

   Node : 18.13.0
   OS   : darwin arm64
   pnpm : 7.24.3
   
   nx : 15.5.1
   @nrwl/angular : Not Found
   @nrwl/cypress : 15.5.1
   @nrwl/detox : Not Found
   @nrwl/devkit : 15.5.1
   @nrwl/esbuild : Not Found
   @nrwl/eslint-plugin-nx : 15.5.1
   @nrwl/expo : Not Found
   @nrwl/express : Not Found
   @nrwl/jest : 15.5.1
   @nrwl/js : 15.5.1
   @nrwl/linter : 15.5.1
   @nrwl/nest : Not Found
   @nrwl/next : 15.5.1
   @nrwl/node : 15.5.1
   @nrwl/nx-cloud : 15.0.2
   @nrwl/nx-plugin : Not Found
   @nrwl/react : 15.5.1
   @nrwl/react-native : Not Found
   @nrwl/rollup : 15.5.1
   @nrwl/schematics : Not Found
   @nrwl/storybook : 15.5.1
   @nrwl/web : 15.5.1
   @nrwl/webpack : 15.5.1
   @nrwl/workspace : 15.5.1
   @nrwl/vite : 15.5.1
   typescript : 4.8.4
   ---------------------------------------
   Local workspace plugins:
   ---------------------------------------
   Community plugins:
         @nxkit/playwright: 2.0.1

Failure Logs

No response

Additional Information

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@sebastiandg7 sebastiandg7 added bug Something isn't working scope:playwright @nxkit/playwright plugin related issues labels Jan 23, 2023
@sebastiandg7 sebastiandg7 self-assigned this Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working scope:playwright @nxkit/playwright plugin related issues
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant