New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] - ADC polling LPADC_GetConvResult #138
Comments
Thanks for reporting the issue, already asked development team to check, reply could be delayed. |
Hi @AndreaRuberti, in MCUX-SDK 2.14 version, the change to the function |
I don't understand. Are you saying that "due to the needs of the NXP Connectivity Team", you are providing an implementation that
I think that is no adequate software quality management. I wonder if there are similar changes hidden somewhere else in SDK 2.14? |
Hi @herrmanthegerman, Sorry that the impact of this change was not fully considered during development, and the current test case hasn't covered the behavior change issue. We will add a test case for it. We have checked the changed parts of the driver in MCUX-SDK version 2.13.1 and 2.14, there are no other similar changes hidden in the driver. We will create a patch ASAP to change the function |
Thanks @ZhaoxiangJin. Just to avoid any misunderstanding: Regarding "similar changes", I was referring to all drivers (see directory drivers/) not only the ADC driver. So which drivers did you check? Thank you for your support. |
Hi @herrmanthegerman, for your information, the team has checked all driver change under the drivers/ folder and confirmed that no similar issue for other drivers. |
Hi, I will close the issue for now. The fix has been applied to latest main branch, please see 1d72f41. |
Describe the bug
Last implementation of function
LPADC_GetConvResult
does not allow correct polling management.To Reproduce
LPADC_DoSoftwareTrigger
.LPADC_DoSoftwareTrigger
.Expected behavior
In polling management, function
LPADC_GetConvResult
should return false in case of not ready value (as in previous SDK 2.13).The 2.14 implementation provide a WHILE loop inside the function that could "stop" the program execution if no data ready.
Furthermore, if no
LPADC_DoSoftwareTrigger
are execute and no WDOG is started... the system loop forever inside LPADC_GetConvResult fx.Screenshots and console output
none
Additional context
if (ADC_RESFIFO_VALID_MASK & base->RESFIFO)
beforeLPADC_GetConvResult
The text was updated successfully, but these errors were encountered: