Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild @nxpm/stack using nx11 #77

Open
4 tasks
beeman opened this issue Jan 23, 2021 · 2 comments
Open
4 tasks

Rebuild @nxpm/stack using nx11 #77

beeman opened this issue Jan 23, 2021 · 2 comments
Assignees

Comments

@beeman
Copy link
Member

beeman commented Jan 23, 2021

Expected Behavior

@nxpm/stack should be built using Nx 11.

Current Behavior

@nxpm/stack is built using Nx 10.

Context

Currently this project is an @nrwl/nx-plugin created with v10. In v11, Nx changed a few things in the structure, mainly around naming schematics -> generators, builders -> executors, architects => targets, and possibly some more.

The generators, besides to having a new name, also have a new way to write them. The commands that run in the generator can now be simply await-ed which makes it (especially with a project like this) easier to write, debug and share them. Those that have worked with schematics probably feel why. In some ways schematics might be easier, but we can wrap around those.

The new version also allows for some structural changes, and will be split up into several packages.

  • @nxpm/api
  • @nxpm/cli
  • @nxpm/stack
  • @nxpm/web
@beeman beeman added this to the @nxpm/stack with Nx 11 milestone Jan 23, 2021
@beeman beeman self-assigned this Jan 23, 2021
@DominikPieper
Copy link
Contributor

A question comes to my mind here. The nxpm/cli creates a workspace without versions pinned and the repo uses v10 and nx-plugin 10. Right now the cli creates a Nx 11 workspace with the Nx 10 plugin which could lead into problems

@beeman
Copy link
Member Author

beeman commented Jan 23, 2021

@DominikPieper that's a good point, in fact I already encountered some unexpected behavior when running my e2e tests.

I worked around this by installing the latest versions of the main tools inside the workspace that gets created for the e2e test.

Luckily, it looks like the generated project does not have any traces of being an Nx 10 workspace, so I think we should be good there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants