Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor/nanocld: db models #679

Merged
merged 14 commits into from
Nov 24, 2023
Merged

refactor/nanocld: db models #679

merged 14 commits into from
Nov 24, 2023

Conversation

leon3s
Copy link
Member

@leon3s leon3s commented Nov 23, 2023

No description provided.

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Attention: 339 lines in your changes are missing coverage. Please review.

Comparison is base (fe1f6df) 57.32% compared to head (62e9806) 57.34%.

Files Patch % Lines
bin/nanocld/src/repositories/vm_spec.rs 0.00% 80 Missing ⚠️
bin/nanocld/src/utils/vm.rs 0.00% 49 Missing ⚠️
bin/nanocld/src/repositories/vm.rs 11.11% 32 Missing ⚠️
crates/nanocl_stubs/src/vm_spec.rs 0.00% 29 Missing ⚠️
bin/nanocld/src/models/vm_spec.rs 0.00% 19 Missing ⚠️
bin/nanocld/src/utils/cargo.rs 65.11% 15 Missing ⚠️
bin/nanocld/src/repositories/vm_image.rs 0.00% 13 Missing ⚠️
bin/nanocld/src/utils/vm_image.rs 0.00% 12 Missing ⚠️
bin/nanocld/src/repositories/node.rs 23.07% 10 Missing ⚠️
bin/nanocld/src/models/vm_image.rs 0.00% 8 Missing ⚠️
... and 24 more
Additional details and impacted files
@@             Coverage Diff             @@
##           nightly     #679      +/-   ##
===========================================
+ Coverage    57.32%   57.34%   +0.02%     
===========================================
  Files          185      185              
  Lines        14977    14927      -50     
===========================================
- Hits          8585     8560      -25     
+ Misses        6392     6367      -25     
Flag Coverage Δ
unittests 57.34% <52.32%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leon3s
Copy link
Member Author

leon3s commented Nov 24, 2023

Need review on this please @anonkey @mamaicode @CreepyPvP there is no way i didn't made a mistake on 2,244 lignes changes

@leon3s
Copy link
Member Author

leon3s commented Nov 24, 2023

The goal:

  • Rename any database model into Db instead of DbModel, so it's shorter.
  • Rename resource config, vm config and cargo config into spec.
  • Use an Arc pointer for the database pool connection for faster clone.
  • Openapi spec have been added aswell cause they where missing.

@leon3s
Copy link
Member Author

leon3s commented Nov 24, 2023

I may merge it to continue on other refactor that need theses change but please take a look at it

@leon3s leon3s merged commit c83a985 into nightly Nov 24, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant