Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/process: Reduce repeated code with process #689

Merged
merged 2 commits into from
Dec 2, 2023
Merged

Conversation

leon3s
Copy link
Member

@leon3s leon3s commented Dec 2, 2023

No description provided.

Copy link

codecov bot commented Dec 2, 2023

Codecov Report

Attention: 133 lines in your changes are missing coverage. Please review.

Comparison is base (467f24e) 55.38% compared to head (8b0ca3b) 54.40%.

❗ Current head 8b0ca3b differs from pull request most recent head 327cc00. Consider uploading reports for the commit 327cc00 to get more accurate results

Files Patch % Lines
bin/nanocld/src/services/process.rs 7.40% 50 Missing ⚠️
crates/nanocl_stubs/src/process.rs 24.00% 38 Missing ⚠️
bin/nanocld/src/models/process.rs 42.85% 16 Missing ⚠️
bin/nanocl/src/models/system.rs 0.00% 9 Missing ⚠️
bin/nanocld/src/utils/system.rs 0.00% 8 Missing ⚠️
bin/nanocl/src/commands/state.rs 76.92% 3 Missing ⚠️
bin/nanocld/src/utils/cargo.rs 86.36% 3 Missing ⚠️
bin/nanocl/src/utils/print.rs 92.00% 2 Missing ⚠️
bin/nanocld/src/schema.rs 92.59% 2 Missing ⚠️
bin/nanocld/src/utils/event.rs 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@             Coverage Diff             @@
##           nightly     #689      +/-   ##
===========================================
- Coverage    55.38%   54.40%   -0.98%     
===========================================
  Files          168      171       +3     
  Lines        14602    14553      -49     
===========================================
- Hits          8087     7918     -169     
- Misses        6515     6635     +120     
Flag Coverage Δ
unittests 54.40% <53.33%> (-0.98%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leon3s leon3s marked this pull request as ready for review December 2, 2023 01:25
@leon3s leon3s merged commit 40509fa into nightly Dec 2, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant