Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apps without Manifest.plist results in crash #17

Closed
minif opened this issue Jun 7, 2022 · 1 comment
Closed

Apps without Manifest.plist results in crash #17

minif opened this issue Jun 7, 2022 · 1 comment

Comments

@minif
Copy link

minif commented Jun 7, 2022

First, I would like to mention that I am using the action-iTunes-header method in a VM, in case this is important.

Lots of (older) apps do not have a Manifest.plist file in SC_Info. One example of such an app I have chosen is this app. The tool assumes the file always exists and uses it to get the names of .sinf files. Because of this, the program crashes with the following message when downloading these apps:
KeyError: "There is no item named 'Payload/tic-tac-toe.app/SC_Info/Manifest.plist' in the archive"

On line 298:
scManifestData = ipaFile.read(appContentDir + '/SC_Info/Manifest.plist')

Some form of check would need to be put in place to ensure Manifest.plist exists, and if it does not use a different method to obtain .sinf files. I think that CFBundleExecutable from info.plist is the name for the .sinf, but I would need to perform more research or testing to confirm this.

@NyaMisty
Copy link
Owner

Fixed. Sorry for the latency :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants