Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to find better class names #3

Closed
nyancrimew opened this issue Jan 3, 2017 · 1 comment
Closed

Try to find better class names #3

nyancrimew opened this issue Jan 3, 2017 · 1 comment
Labels
api enhancement

Comments

@nyancrimew
Copy link
Owner

nyancrimew commented Jan 3, 2017 •
edited

The Pr* naming scheme isn't that beautiful, we should find a new scheme and also check method names.

We can't simply remove the Pr Prefix if we want to avoid problems with java.lang wrapper classes. We also shouldn't just remove it where possible to keep a pattern throughout our api.
@nyancrimew
Copy link
Owner Author

nyancrimew commented Jan 3, 2017 •
edited

An option would be to use plural forms like Longs or Bytes

nyancrimew added a commit that referenced this issue Jan 3, 2017
@nyancrimew
Rename classes to the plural forms of the types (#3)
c19263a 
This drops the Pr prefix
nyancrimew added a commit that referenced this issue Jan 3, 2017
@nyancrimew
Reflect API changes in documentation (#3)
e3d4bb9
@nyancrimew nyancrimew changed the title Try to find better class / api names Try to find better class names Jan 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nyancrimew