Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering Docs #14

Closed
hbiyik opened this issue Jan 22, 2024 · 5 comments
Closed

Rendering Docs #14

hbiyik opened this issue Jan 22, 2024 · 5 comments

Comments

@hbiyik
Copy link

hbiyik commented Jan 22, 2024

I am giving the rendering wiki page update as a patch, i think gh does not support prs for wiki.

Basically documents how to get acceleration on mpv and kodi including afbc support as well.

rendering-docs.patch.tar.gz

depends on
#13
#4
75eca72 (afbc stride issue)

Preview is here:
https://github.com/hbiyik/ffmpeg-rockchip/wiki/Rendering

@hbiyik
Copy link
Author

hbiyik commented Jan 27, 2024

And here is the patch with latest PRs
rendering-docs_v2.patch.tar.gz

@nyanmisaka
Copy link
Owner

// 0002-Support-P210-LF.patch
@@ -624,6 +625,7 @@ pipe_format_to_chroma_format(enum pipe_format format)
       case PIPE_FORMAT_P010:
       case PIPE_FORMAT_P012:
       case PIPE_FORMAT_P016:
+      case PIPE_FORMAT_P210:
       case PIPE_FORMAT_P030:
       case PIPE_FORMAT_Y16_U16_V16_420_UNORM:
          return PIPE_VIDEO_CHROMA_FORMAT_420;

Shouldn't it be PIPE_VIDEO_CHROMA_FORMAT_422?

@hbiyik
Copy link
Author

hbiyik commented Jan 28, 2024

yes, i have also looked at what i have done in P210 mesa patchset, there are alot of mistakes in there. But the biggest mistake is its existance :).

Mesa upstream or panfork both supports P210 through egl without any patchset, so those need to be removed.

I will send an update, but could you have a look at these, if merged, i will update docs to use force_yuv=uncompact

@hbiyik
Copy link
Author

hbiyik commented Jan 28, 2024

here is the v3 with latest changes

rendering-docs_v3.patch.tar.gz

@nyanmisaka
Copy link
Owner

Done in https://github.com/nyanmisaka/ffmpeg-rockchip/wiki/Rendering

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants