Tests depend on deterministic ordering of attributes

[rowanseymour]

django-hamlpy/hamlpy/elements.py

Line 137 in 9224b44

attributes_dict = eval(attribute_dict_string)

evaluates a parsed attribute dictionary as a Python dict, but that means attribute ordering is non-deterministic.

This leads to tests sometimes failing which depend on order, e.g.

django-hamlpy/hamlpy/test/test_elements.py

Line 52 in 37d63ad

eq_(sut.attributes, "a='something' c='2' b")

Question is whether html attribute order should match haml attribute order?

[Psycojoker]

I think that we should try to finish this other branch https://github.com/Psycojoker/django-hamlpy/tree/element_parser that, apparently, uses a real parser. This will solve this issue and avoid potential other ones generated by using regex to transform the attributes into a python dict.

[rowanseymour]

Yeah the regex approach is certainly fragile... do you know how close to finished that branch is?

[Psycojoker]

Sadly no, I've only saw it since someone proposed it to be merged jessemiller#147 so I guess it's at least close to being ready.

[rowanseymour]

Looks like it has diverged quite a bit from master and doesn't run on Python 2.7.

How would you feel about this as temporary workaround 9e53689 ?

[Psycojoker]

This fix seems totally acceptable in this situation for me.