New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does not compile under Node v12+ #9

Open

jnovack opened this issue Jun 10, 2020 · 1 comment

Labels

Member

jnovack commented Jun 10, 2020 •

edited

Loading

ToBoolean(), and ToString() are V8_DEPRECATED and need rewriting in order to work under Node 12+.

/root/.cache/node-gyp/12.18.0/include/node/v8.h:2664:59: note: declared here
 2664 |                 V8_WARN_UNUSED_RESULT MaybeLocal<Boolean> ToBoolean(
      |                                                           ^~~~~~~~~
/root/.cache/node-gyp/12.18.0/include/node/v8config.h:328:3: note: in definition of macro 'V8_DEPRECATED'

The text was updated successfully, but these errors were encountered:

jnovack added the help wanted label

jnovack mentioned this issue

Node version for storm-replay nydus/heroprotocol#21

Closed

Member Author

jnovack commented Jun 10, 2020

See bcoin-org/bcrypto#7 for information or assistance.

jnovack pinned this issue

jnovack changed the title ~~Does not compile under Node 12~~ Does not compile under Node v12+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment