-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Foobar2k crashes immediately when playing BGMs which stored in thbgm.dat #2
Comments
Seems that this plugin doesn't like ESLyric. The music plays fine if I disable "foo_uie_eslyric.dll" But... What's happenning with the progress bar? |
foo_thbgm will hook the progress bar because all touhou BGM's can loop |
Can I disable the inf-looping feature? |
sure, you can set loop_count to 1 in the playback menu |
Aha, finally i found the issue about ESLyric. That crazy plugin will try to iterate all other plugin's get_info interface when playing musics. This is very hackish and may conflict with many other plugins. You can also see in the stack dump. Anyway, if you really need to use ESLyric, I can also do a test build for you to forbid ESLyric visiting foo_thbgm's interface. |
Good! But instead of "forbiding ESLyric visiting foo_thbgm's interface", could you return some data which is not THAT special, to make ESLyric ignore it safely. It's always not a good idea to hack code for some specified things since other plugins may have the same issue |
Yes, I'll do these work this weekend, only because the modification has no downsides. |
dump file uploaded: |
Detail information updated on the thread of Eslyric in Baidu Tieba |
now Eslyric can read music data properly and will no longer conflict with each other, plz check the latest build and confirm |
Confirmed, thanks |
Tested th13, th14 and th14.3. All of them crashes foobar2000.
But th13.5 and th14.5 works fine
Plugin downloaded from: http://bbs.nyasama.com/forum.php?mod=viewthread&tid=47702
Version: foobar2000 1.3.8 ( Chinesized by Asion ) with foobox 4.1
Crash log:
The text was updated successfully, but these errors were encountered: