Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Oops, one bug that slipped testing!
Test code:
This doesn't work, because ...
https://github.com/nyjc-computing/pseudo/blob/660d9fd53224954cf78282b4d79d06271ef7f4dc/parser.py#L88-L95
Our
unary()
parser is too generous, parsing an entire expression, which gives us-(1 = -1)
instead of((-1) = (-1))
.Simple fix: parse with
value()
instead ofexpression()
:e4bdb4a