Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Setup code coverage & reporting. #40

Open
dweremeichik opened this issue Jul 18, 2017 · 4 comments
Open

Setup code coverage & reporting. #40

dweremeichik opened this issue Jul 18, 2017 · 4 comments

Comments

@dweremeichik
Copy link
Member

It has become apparent that we need proper automated testing and code coverage reports. This issue is a request for the latter.

@asaphaaning
Copy link

asaphaaning commented Jul 19, 2017

With limited time over the summer and a conflicting lust to participate in this, maybe this is a small problem I can assist with in the coming months.

Do we need large automation systems like jenkins/buildbot or could something built ourselves do the trick, something like hack of cron and some scripting? The reason I ask this is because I haven't built it myself yet so I don't know how many processes goes into it and how the testbench is performed.

@dweremeichik
Copy link
Member Author

I was thinking along the lines of using Istanbul's NYC and coveralls. I don't think it should be too crazy to setup. We already use Travis and are in the process of setting up appveyor, so testing isn't a problem, there really aren't many tests at this point though.

@kontrollanten
Copy link

Is there any tests at all written today? I can make a PR with nyc and coveralls, but as far as I understand the only tests that runs within the npm test commands are electrons internal tests? When I run the coverage I get 0. But at least there's something to start with. :-)

@dweremeichik
Copy link
Member Author

Sorry, missed your comment on this. Yeah, there aren't really many tests at this point. The ones that do exist may not cover much.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants