Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request - Select the right email alias when replying #3462

Open
yehiasalam opened this issue Apr 23, 2017 · 2 comments
Open

Feature Request - Select the right email alias when replying #3462

yehiasalam opened this issue Apr 23, 2017 · 2 comments

Comments

@yehiasalam
Copy link

Hello,

Super useful, found in Gmail and Inbox. When im replying to an email to send to an alias, the from field when im composing is automatically send with the alias it was send to.

I'll try when I have time to fork and do a pull request. Very neat product btw.

@yehiasalam
Copy link
Author

well, it looks likes i should change something along the below lines in the draft factory in draft-factory.js, however not sure if there will be any affected areas

    DraftFactory.prototype.createOrUpdateDraftForReply = function(arg) {
      var behavior, message, thread, type;
      message = arg.message, thread = arg.thread, type = arg.type, behavior = arg.behavior;
      if (type !== 'reply' && type !== 'reply-all') {
        throw new Error("createOrUpdateDraftForReply called with " + type + ", not reply or reply-all");
      }
      return this.candidateDraftForUpdating(message, behavior).then((function(_this) {
        return function(existingDraft) {
          if (existingDraft) {
            return _this.updateDraftForReply(existingDraft, {
              message: message,
              thread: thread,
              type: type
            });
          } else {
            return _this.createDraftForReply({
              message: message,
              thread: thread,
              type: type
            });
          }
        };
      })(this));
    };

@yehiasalam
Copy link
Author

yehiasalam commented Apr 24, 2017

submitted a hot fix here #3473, please merge 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant