Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect type for SchedulerBookingOpeningHoursProperties.days #328

Closed
sunil-zaya opened this issue Mar 9, 2022 · 1 comment · Fixed by #330
Closed

Incorrect type for SchedulerBookingOpeningHoursProperties.days #328

sunil-zaya opened this issue Mar 9, 2022 · 1 comment · Fixed by #330
Assignees
Labels

Comments

@sunil-zaya
Copy link

Describe the bug
In "Create a Scheduling Page" API, under config > booking > opening_hours, "days" is required to be an array of strings. But in the SDK, "days" is declared as a string.

To Reproduce
The following code will trigger a Typescript error:

  const config = new SchedulerConfig({
    booking: {
      openingHours: [{
        days: ["M", "T", "W", "R", "F"],
      }],
    },
  });

Expected behavior
"days" should be declared as string[] instead.

SDK Version:
6.2.0

@sunil-zaya sunil-zaya added the bug label Mar 9, 2022
@mrashed-dev mrashed-dev self-assigned this Mar 9, 2022
@mrashed-dev
Copy link
Collaborator

@sunil-zaya Thank you for submitting this issue, we are taking a look at this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants