Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Custom themes don't work #35

Closed
Sh1d0w opened this issue Aug 29, 2023 · 3 comments
Closed

[BUG] Custom themes don't work #35

Sh1d0w opened this issue Aug 29, 2023 · 3 comments

Comments

@Sh1d0w
Copy link

Sh1d0w commented Aug 29, 2023

Hello, thanks for the great framework!

According to the documentation you can create custom themes:

https://nylo.dev/docs/5.x/themes-and-styling#creating-a-theme

This all is good. You can also switch the theme to the custom one:

NyTheme.set(context, id: "custom_theme");

However the problem occurs when using the colours from the theme:

ThemeColor.get(context).primaryContent

Because it defaults to either the light or dark theme here https://github.com/nylo-core/support/blob/5.x/lib/helpers/helper.dart#L554 it won't use the theme you set with NyTheme.set which makes it pointless.

The way it should work is to use the correct theme set by NyTheme.set.

@agordn52
Copy link
Contributor

Hi @Sh1d0w,

I'll take a look at my earliest convenience.

@agordn52
Copy link
Contributor

This is fixed in v5.3.5.

Thanks for highlighting the issue 👍

@Sh1d0w
Copy link
Author

Sh1d0w commented Sep 1, 2023

Thanks, works great 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants