respond to comments

clay · Aug 20, 2015 · 20e4962 · 20e4962
1 parent b12a3d4
commit 20e4962
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 30 deletions.
diff --git a/publishing-rules/ban-tk.js b/publishing-rules/ban-tk.js
@@ -3,7 +3,7 @@ var label, description,
   articleFields = ['primaryHeadline', 'teaser'],
   paragraphField = 'text',
   _ = require('lodash'),
-  dom = require('../services/dom'),
+  stripTags = require('striptags'),
   references = require('../services/references'),
   refProp = references.referenceProperty,
   cutStart = 20,
@@ -84,7 +84,7 @@ function addError(component, fieldName, errors, tkText) {
     data = component && component[fieldName],
     schema = data._schema,
     label = schema && schema._label,
-    value = data && data.value && dom.removeTags(data.value),
+    value = data && data.value && stripTags(data.value),
     error = {
       ref: ref,
       fieldName: fieldName,
@@ -107,7 +107,7 @@ function validate(state) {
 
   _.each(groups.paragraph, function (component) {
     var field = component[paragraphField],
-      value = field && field.value && dom.removeTags(field.value),
+      value = field && field.value && stripTags(field.value),
       tkText = value && findFirstText(value, searchTexts);
 
     if (tkText) {
@@ -120,7 +120,7 @@ function validate(state) {
   _.each(groups.article, function (component) {
     _.each(articleFields, function (fieldName) {
       var field = component[fieldName],
-        value = field && field.value && dom.removeTags(field.value),
+        value = field && field.value && stripTags(field.value),
         tkText = value && findFirstText(value, searchTexts);
 
       if (tkText) {

diff --git a/services/dom.js b/services/dom.js
@@ -211,23 +211,5 @@ module.exports = {
     observer.observe(el.parentNode, {childList: true});
   },
 
-  /**
-   * Remove HTML tags from string
-   * @param {string} str
-   * @returns {string}
-   */
-  removeTags: function (str) {
-    var start = str.indexOf('<'),
-      end = start > -1 && str.indexOf('>', start) || start;
-
-    while (start > -1 && end > -1) {
-      str = str.substring(0, start) + str.substring(end + 1);
-      start = str.indexOf('<');
-      end = start > -1 && str.indexOf('>') || start;
-    }
-
-    return str;
-  },
-
   create: domify // create elements from strings!
 };
diff --git a/services/dom.test.js b/services/dom.test.js
@@ -189,12 +189,4 @@ describe('dom service', function () {
       expect(mockMutationObserver.disconnect.callCount).to.equal(1);
     });
   });
-
-  describe('removeTags', function () {
-    var fn = dom[this.title];
-
-    it('removes tags', function () {
-      expect(fn('a<>c<d>e<f>g</h>')).to.equal('aceg');
-    });
-  });
 });