Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

component property editing #1042

Merged
merged 3 commits into from Dec 5, 2017
Merged

component property editing #1042

merged 3 commits into from Dec 5, 2017

Conversation

nelsonpecora
Copy link
Contributor

@nelsonpecora nelsonpecora commented Dec 4, 2017 •
edited

  • fixes Placeholder does not work with _component property #751
  • allows removal of editable component properties
  • allows placeholder for empty component properties
  • allows adding components to empty component properties
  • removes (unused) code for "replacing" components in properties (just remove, then add)

Note: As of kiln 5, the "replace" code wasn't actually connected to anything. It presented a completely different affordance from other ways of manipulating components, so I decided to scrap the whole idea. This is a lot cleaner now.

@nelsonpecora nelsonpecora self-assigned this Dec 4, 2017
@nelsonpecora nelsonpecora merged commit 7e4f2b0 into master Dec 5, 2017
@nelsonpecora nelsonpecora deleted the component-props branch April 17, 2018 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amycheng amycheng amycheng approved these changes

Assignees

@nelsonpecora nelsonpecora

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Placeholder does not work with _component property
2 participants
@nelsonpecora @amycheng