Removes Elastic type #1126
Merged
Removes Elastic type #1126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonwinton
previously approved these changes
Mar 5, 2018
jonwinton
approved these changes
Mar 6, 2018
cperryk
force-pushed
the
elastic-6.2
branch
3 times, most recently
from
505fcb7
to
23d008e
Compare
Removes Elastic type Expect beta amphora-search 6.0.0-beta.1 Expect amphora-search 6.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Do not merge until amphora-search 6 is released)
We're upgrading amphora-search to use Elastic 6. As part of this effort, we are having amphora-search automatically set document type in requests sent to the
_searchendpoint. This is because only one type is allowed per index in Elastic 6 anyway. By making it amphora-search's responsibility to set the type, we don't have to change Kiln again when migrating to future versions of Elastic, which will remove document types entirely.