Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

collapsible complex-list items #1193

Merged
merged 3 commits into from
Apr 25, 2018
Merged

collapsible complex-list items #1193

merged 3 commits into from
Apr 25, 2018

Conversation

nelsonpecora
Copy link
Contributor

@nelsonpecora nelsonpecora commented Apr 25, 2018 •
edited
Loading

  • complex-list now supports collapsible items!
  • you can make a complex-list collapsible with the collapse argument
  • specify what property you want to display as the title of the item when it's collapsed (if that property is empty, it'll say "New Item")
  • only one item may be expanded at a time. this is the current item! (same item that gets the action buttons at the bottom)

byronhulcher
byronhulcher reviewed Apr 25, 2018
View reviewed changes
inputs/complex-list-item.vue
}
},
methods: {
enter(el, done) {
this.$nextTick(() => {
velocity(el, 'fadeIn', { duration: 375, complete: done });
velocity(el, 'fadeIn', { duration: 250, complete: done });
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100% here for shorter transition times

byronhulcher
byronhulcher approved these changes Apr 25, 2018
View reviewed changes
Copy link
Contributor

@byronhulcher byronhulcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 lgtm

@nelsonpecora nelsonpecora merged commit 098378d into master Apr 25, 2018
@nelsonpecora nelsonpecora deleted the complex-collapse branch April 25, 2018 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byronhulcher byronhulcher byronhulcher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nelsonpecora @byronhulcher