Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disallow scheduling in the past #1208

Merged
merged 3 commits into from May 9, 2018
Merged

disallow scheduling in the past #1208

merged 3 commits into from May 9, 2018

Conversation

nelsonpecora
Copy link
Contributor

@nelsonpecora nelsonpecora commented May 9, 2018 •
edited

  • disable the schedule button when the date/time are set to sometime in the past
  • tested against keyboard input (hitting enter in that form) as well
  • fixes prevent scheduling in the past #1205

cperryk
cperryk approved these changes May 9, 2018
View reviewed changes
Copy link
Contributor

@cperryk cperryk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor suggestion

lib/drawers/publish.vue Outdated
@@ -237,6 +238,14 @@
}
}

function isInThePast(dateValue, timeValue) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add code comments that make it clear what dateValue and timeValue are?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point

@nelsonpecora nelsonpecora merged commit 3e42ae7 into master May 9, 2018
@nelsonpecora nelsonpecora deleted the page-of-future-past branch May 9, 2018 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cperryk cperryk cperryk approved these changes

@amycheng amycheng amycheng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

prevent scheduling in the past
3 participants
@nelsonpecora @cperryk @amycheng