easy fixes #1325
Closed
easy fixes #1325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmfarrell
force-pushed
the
placeholders-cleanup
branch
from
5fc714d
to
fb51fa9
Compare
rmfarrell
commented
Sep 6, 2018
| @@ -167,8 +168,6 @@ export function hasPlaceholder(uri, path, storeOverride = store) { | |||
| isCollapsibleList = isComponentList && !!_.get(schema, `${componentListProp}.collapse`), | |||
| isComponentProp = schema && !!schema[componentProp]; | |||
|
|
|||
| // if there isn't a placeholder at all, return negative quickly | |||
| // since we're ususally checking a bunch of fields/groups | |||
| if (!placeholder) { | |||
| return false; | |||
| } | |||
There was a problem hiding this comment.
no explanation needed for early returns because they're the best. It's so much nicer reserving your unindented code for your main logical branch and your indented code for early returns, error handling, etc.
nelsonpecora
reviewed
Sep 7, 2018
| _.each(placeholders[uri], (placeholder) => placeholder.$destroy()); | ||
| placeholders[uri] = null; | ||
| } | ||
| placeholders[uri] && placeholders[uri].forEach((ph) => ph.$destroy()); |
There was a problem hiding this comment.
this doesn't remove / nullify placeholders[uri]
nelsonpecora
approved these changes
Sep 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1324