Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wysiwyg toolbar button fix #162

Merged
merged 2 commits into from Aug 14, 2015
Merged

wysiwyg toolbar button fix #162

merged 2 commits into from Aug 14, 2015

Conversation

nelsonpecora
Copy link
Contributor

Buttons weren't updating after you created a wysiwyg field the first time. Now they're good every time.

trello ticket

@@ -377,6 +377,12 @@ module.exports = function (result, args) {
// put the rich text field after the input
dom.replaceElement(textInput, field);

function findExtension(extname) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JSDoc, otherwise all good.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 81.071% when pulling 25c847e on wysiwyg-toolbar into 15354e9 on master.

@nelsonpecora
Copy link
Contributor Author

there's a ticket open regarding adding tests to wysiwyg :-)

nelsonpecora added a commit that referenced this pull request Aug 14, 2015
@nelsonpecora nelsonpecora merged commit 67b82e9 into master Aug 14, 2015
@nelsonpecora nelsonpecora deleted the wysiwyg-toolbar branch August 14, 2015 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants