site-specific components in component lists #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| function availableOnCurrentSite(slug, logic) { | ||
| var tokens = logic.split(',').map((str) => str.trim()), // trim any extra whitespace | ||
| // list of site slugs to include | ||
| include = _.reject(tokens, (token) => _.includes(token, 'not:')), |
There was a problem hiding this comment.
could you call these "sitesToInclude" "sitesToExclude"? Self-documenting variable names!
|
👍 with some minor comments about comments |
| - article (site1, site2) # allow on site1 and site2 ONLY | ||
| - paragraph # allow on all sites | ||
| - image (not:site1) # allow on all sites EXCEPT site1 | ||
| - link (site1, site2, site3, not:site2, not:site3) # only allow on site1 |
There was a problem hiding this comment.
Hmm, do site-specific options belong in the schema? Seems like schema should be only tied to the component and generic to any site.
There was a problem hiding this comment.
as a less-used +1, I think this is fine, especially since it's only for implementation-specific components (adding specific sites to a list in a component on npm would be dumb)
|
👍 from byron |
|
Thanks for the improvements @yoshokatana 👍 |
|
WHOAH |
|
WHOAH WHOAH WOOOOOOOAH |
|
@byronhulcher @cruzanmo should we revert this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #492
allows you to specify that certain components in lists should be included/excluded only on certain sites