Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add formatUrl transform to magic button #694

Merged
merged 2 commits into from Nov 28, 2016
Merged

Conversation

fraddski
Copy link
Contributor

@fraddski fraddski commented Nov 28, 2016

Adds a new transform formatUrl to the magic button, as well as a new optional transformArg property which is passed to transforms. This allows the button to take a field and transform it to a url of a given format.

This is required for the episode recap component for Vulture, which needs a magic button to automatically create an image url based on the show name.

Copy link
Contributor

@nelsonpecora nelsonpecora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Could you add this new argument to the magic-button.md docs before this is merged?

@coveralls
Copy link

Coverage Status

Coverage increased (+1.2%) to 76.872% when pulling 1d0c1d5 on magic-button-format into 8d8eb6b on master.

@fraddski fraddski merged commit b112b82 into master Nov 28, 2016
@fraddski fraddski deleted the magic-button-format branch November 28, 2016 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants