Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redesigned status messages #701

Merged
merged 7 commits into from Dec 5, 2016
Merged

redesigned status messages #701

merged 7 commits into from Dec 5, 2016

Conversation

nelsonpecora
Copy link
Contributor

@nelsonpecora nelsonpecora commented Dec 5, 2016

  • trello ticket
  • new semantic colors (slightly more pastel than before)
  • larger status message (now that they aren't permanent)
  • removed permanent status messages (schedule and publish)
  • merged page and layout colors into save (blue)
  • created progress.error convenience method to pass errors through
  • note: offline status message will be permanent until you reconnect
  • passing in error messages directly to error status messages now

screen shot 2016-12-05 at 4 13 42 pm

screen shot 2016-12-05 at 4 14 31 pm

screen shot 2016-12-05 at 4 15 43 pm

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 75.015% when pulling 86486ed on status-messages into 58b57d4 on master.

}

openPublish(results);
return openPublish(results);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return this promise, so any issues will flow down to the .catch() below

@coveralls
Copy link

Coverage Status

Coverage increased (+0.6%) to 75.494% when pulling d62eb9a on status-messages into 58b57d4 on master.

@gloddy
Copy link
Contributor

gloddy commented Dec 5, 2016

browserstack!!

@nelsonpecora
Copy link
Contributor Author

more like...

( •_•)>⌐■-■

BOWSER stack

(⌐■_■)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 75.015% when pulling d62eb9a on status-messages into 58b57d4 on master.

@nelsonpecora nelsonpecora merged commit 8016c89 into master Dec 5, 2016
@nelsonpecora nelsonpecora deleted the status-messages branch December 5, 2016 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants