Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposes layout object to validators #708

Merged
merged 3 commits into from
Dec 29, 2016
Merged

Exposes layout object to validators #708

merged 3 commits into from
Dec 29, 2016

Conversation

cperryk
Copy link
Contributor

@cperryk cperryk commented Dec 16, 2016

This change passes the layout object to validation functions so we can develop layout-specific rules. (Relevant Trello)

@coveralls
Copy link

Coverage Status

Coverage increased (+1.1%) to 73.087% when pulling 9554a5f on layout-in-validation into d8c7431 on master.

@jonwinton
Copy link
Contributor

This would also require an update of documentation: https://github.com/nymag/clay-kiln/blob/master/validators/README.md

@coveralls
Copy link

Coverage Status

Coverage increased (+1.03%) to 72.999% when pulling e1bf878 on layout-in-validation into d8c7431 on master.

@nelsonpecora
Copy link
Contributor

👍🏼 from sunny CA

@cperryk cperryk merged commit e306f92 into master Dec 29, 2016
@cperryk cperryk deleted the layout-in-validation branch December 29, 2016 15:34
@nelsonpecora
Copy link
Contributor

note: in kiln v1.0, we're passing the full state object, so you can grab the layout uri (state.page.data.layout) or data (state.components[layoutURI]) in the validator yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants