Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding back selected-parent class #713

Merged
merged 2 commits into from Dec 27, 2016
Merged

Adding back selected-parent class #713

merged 2 commits into from Dec 27, 2016

Conversation

jonwinton
Copy link
Contributor

As components grow more complex, sometimes we need to write styles specific to edit mode. Sometimes in this situation we need awareness of when a component's parent is selected. There used to be a class for this, but in some updates it seems to have been removed. This adds that class back in.

Example
The in-article-slideshow component has a component-list of slides. If we want these all to be editable we need to show them all on the page, which makes the page very long and makes it so that the component cannot be dragged to different locations on the page. By having selected mode styles only we can maintain it's proper appearance and only expand it when we want to edit the component.

When not editing
screen shot 2016-12-27 at 10 33 03 am

When Editing
screen shot 2016-12-27 at 10 33 20 am

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.0%) to 72.851% when pulling 694d7b8 on parent-is-editing into 9ca5989 on master.

@dmabuada
Copy link
Contributor

looks ok. +1

@jonwinton jonwinton merged commit d8c7431 into master Dec 27, 2016
@jonwinton jonwinton deleted the parent-is-editing branch December 27, 2016 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants