remove server.js and non-handlebars support from kiln #898
Conversation
| @@ -1,4 +1,4 @@ | |||
| import { includes } from 'lodash'; | |||
| import _ from 'lodash'; | |||
There was a problem hiding this comment.
Maybe you should uhhhhhhh use _.includes for this later in the file? And also write tests? and maybe also test your code???????????????????
There was a problem hiding this comment.
lol this is funny...how did this even..work?
There was a problem hiding this comment.
shift-clay.js is pretty simple logic, but would be non-trivial to test. thanks for catching that syntax error tho!
| @@ -67,7 +67,7 @@ export function getListData(store, { uri, prefix }) { | |||
| size: 1, | |||
| query: { | |||
| term: { | |||
| uri // match page uri | |||
| uri: replaceVersion(uri) // match page uri (removing @published or @scheduled) | |||
There was a problem hiding this comment.
replace version or remove version? the pages index doesn't have any version appended to its document keys
There was a problem hiding this comment.
replaceVersion is the name of the function; if passed a single argument it'll remove any version that's applied (or just pass through the uri, if it doesn't have a version)
serverSaveandserverSaveAndRerendermodel.jsin order to do client-side optimistic saving + re-rendering (no more passthroughmodel.jsfiles!)kiln-view-public.jsrendering size (28k → 12k unminified)