add people to current page #900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nelsonpecora
commented
Aug 30, 2017
nelsonpecora
commented
- allows adding other people to the current page
- allows you to search through directory of people, to find the best person
- this does not notify the person added, but does put the page in their "My Pages" list
mheiber
reviewed
Aug 30, 2017
panes/add-person-to-page.vue
Outdated
| addPersonToPage(user) { | ||
| this.$store.dispatch('startProgress', 'save'); | ||
| return this.$store.dispatch('updatePageList', { user }).then(() => { | ||
| this.$store.dispatch('finishProgress', 'save'); |
There was a problem hiding this comment.
I'd recommend adding finishProgress and closing the pane and such to the catch for the promise as well, unless the error handling is already happening elsewhere
There was a problem hiding this comment.
Good point, I need to catch that if it fails for some reason
mheiber
reviewed
Aug 30, 2017
| import { postJSON } from '../lib/core-data/api'; | ||
| import { searchRoute } from '../lib/utils/references'; | ||
|
|
||
| function buildUserQuery(query) { |
There was a problem hiding this comment.
nit:
buildUserQuery isn't a UI thing—by pulling it out of the Vue file it would be easier to test
There was a problem hiding this comment.
Eh, the logic for it is super simple. There's not much to test 😅
|
code LGTM modulo 2 nits. Want me to run it and test in a browser? |
jonwinton
approved these changes
Aug 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.