Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate settings #21

Closed
veltman opened this issue Jul 30, 2016 · 2 comments
Closed

Validate settings #21

veltman opened this issue Jul 30, 2016 · 2 comments
Labels
enhancement
Milestone
v1.0

Comments

@veltman
Copy link
Contributor

veltman commented Jul 30, 2016

These conditions will all result in an error, would be nice to validate them on startup and provide descriptive error messages:

  • Missing workingDirectory
  • No storagePath or s3Bucket
  • Non-numeric value for maxUploadSize
  • Invalid fonts array
  • Missing fonts files
  • Non-string redisHost

Could also provide warnings about:

  • Improperly formatted themes
  • Themes missing required options

Missing AWS credentials are already handled by a headBucket() test on startup.
@veltman
Copy link
Contributor Author

veltman commented Jul 31, 2016

If settings were pre-processed in this way, we could squash the various path.isAbsolute() calls, which is currently the only thing necessitating a newer than v0.10.0 version of Node (I think).

@veltman veltman mentioned this issue Aug 1, 2016
Closed
@veltman veltman added this to the v1.0 milestone Aug 1, 2016
@veltman
Copy link
Contributor Author

veltman commented Oct 12, 2016

Merged to master.

@veltman veltman closed this as completed Oct 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v1.0
Development

No branches or pull requests
1 participant
@veltman