Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG reload page V.2 in DEMO page and when using #14

Closed
choonoi opened this issue Jan 13, 2011 · 11 comments
Closed

BUG reload page V.2 in DEMO page and when using #14

choonoi opened this issue Jan 13, 2011 · 11 comments

Comments

@choonoi
Copy link

choonoi commented Jan 13, 2011

I'm using Firefox , IE6 ,IE 7 , IE 8 and get error.
when i click link to open modal ajax and I click link in that modal to open new page or reload in modal it's not reload or not working if click same link and found error.

Webpage error details

Message: 'data(...).elts' is null or not an object
Line: 225
Char: 6
Code: 0
URI: http://localhost/java/nyroModal/js/jquery.nyroModal.custom.js

----------- the error line is --------
if (!this.stack && this.getInternal().stack.length > 1)
this.elts = $(_internal.stack[_internal.stack.length-2]).data('nmObj').elts; <--

Thank you for great Modal

@nyroDev
Copy link
Owner

nyroDev commented Jan 13, 2011

Even if I understand the problem, I can't reproduce it.
Could you tell me how you to reproduce it please?

@choonoi
Copy link
Author

choonoi commented Jan 13, 2011

I just remove that 2 lines then it work fine for me.
but I dont understand well what is that line for?

@nyroDev
Copy link
Owner

nyroDev commented Jan 13, 2011

This line is about stacking. They are useful when you want not stackable modal in order to use the same HTML elts for a new modal

@choonoi
Copy link
Author

choonoi commented Jan 13, 2011

how about if i change that line like this ?

this.elts = $(_internal.stack[_internal.stack.length-1]).data('nmObj').elts;

getInternal().stack.length >1 so how about if just -1
because if - 2 it will be empty ?

i did not check all code because i really don't understand much about it.

but it also work fine just -1 "_internal.stack[_internal.stack.length" so
data('nmObj') will not null or empty. am i right?

@andrelaszlo
Copy link

I had the same problem and choonois solution worked for me as well. I'm not using stacking.

@andrelaszlo
Copy link

Also, the bug doesn't seem to be browser specific.

@nyroDev
Copy link
Owner

nyroDev commented Jan 22, 2011

Could someone tell me exactly how can I reproduce this bug please?
the code mentionned here was added to fix a bug, so it should stay here.

@andrelaszlo
Copy link

The bug is reproduced here: http://andre.laszlo.nu/nyroModal/issue14.html
Download the code as a zip file here: http://andre.laszlo.nu/nyroModal/issue14.zip

@adrianoh
Copy link

This error is reproduced here too: http://nyromodal.nyrodev.com/ in the example: "simple form filtering content" button, when windows apear, click en "new modal", and in new windows, click in button "new modal from a form". The error is here.

@adrianoh
Copy link

In the "simple form" example, from http://nyromodal.nyrodev.com/ error is reproduced too.

@nyroDev
Copy link
Owner

nyroDev commented Feb 25, 2011

Update documentation in Readme file
Add swfObjectId settings and use it in filters.swf or create an uniq ID. Closed by 3fafa30
Add recalc settings for nm.resize function to force the recalculation of the modal. Closed by 3fafa30 Closed by 3fafa30
Fix issue with jQuery 1.5 on IE8 (bogus selector in filters.swf). Closed by 3fafa30
Fix stack error when reopening a modal. Closed by 3fafa30
Add initFilters callbacks in order to force filters. Closed by 3fafa30 Closes#37
Add afterReposition and afterUnreposition callbacks.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants