This repository has been archived by the owner on Dec 23, 2023. It is now read-only.
Allow a Rosetta download for macos/Apple Silicon #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # we overwrite the architecture | ||
| if [ $platform = "macos" -a $architecture = "armv7" ]; then | ||
| echo "Exa does not have Apple Silicon releases yet. See https://github.com/nyrst/asdf-exa/issues/1" | ||
| architecture="x86_64" |
There was a problem hiding this comment.
Hello, thanks for this, I admit that I forgot about this after briefly trying to fetch a binary from homebrew but this needs other tools to work correctly (for example jq to parse the json file from homebrew and fetch the correct file etc...)
Anyway, I think we should just exit here instead of setting the architecture and let the program fo forward. What do you think about this?
There was a problem hiding this comment.
I'd need this patch anyway because I specifically want to install exa on my ARM macbook :D
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1