Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Side Animation slides in the background #15

Closed
timothystewart6 opened this issue May 30, 2019 · 4 comments
Closed

Side Animation slides in the background #15

timothystewart6 opened this issue May 30, 2019 · 4 comments

Comments

@timothystewart6
Copy link

timothystewart6 commented May 30, 2019

Hi. Nice component! I am seeing an issue with the slide animation where the background also slides in along with the bottom sheet. From the example screenshots, it looks like the background should fade in - in both scenarios (slide and fade) however it seems like the transparent background slides in along with the bottom sheet when it is set to slide.

  <RBSheet
          closeOnDragDown
          ref={ref => {
            this.RBSheet = ref
          }}
          height={360}
          duration={300}
          animationType="slide"
          customStyles={{
            container: {
              ...styles.header,
            },
          }}
        >
          {this.renderBottomSheet()}
   </RBSheet>
@timothystewart6
Copy link
Author

I think this just might be a simulator / dev issue or a duration setting issue. I will see if I can narrow it down or just close the issue.

@nysamnang
Copy link
Owner

@timothystewart6 There is nothing wrong. If you set props animationType="slide" it means the background animation is gonna slide up along with the bottom sheet. I'm not recommend to use slide but i'm sure in some cases user will need it that's why we should have this props for user choices.

@timothystewart6
Copy link
Author

Thanks for the clarification! Working as designed :) I can totally see a use case for this now that you mention it, however not for mine. Thank you!

@Gutyn
Copy link

Gutyn commented Dec 12, 2020

@timothystewart6 did you find a way to do the sliding correctly? maybe separate the background animations somehow?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants