Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot use ::class with dynamic class name #7

Closed
ArpadGBondor opened this issue Feb 8, 2024 · 3 comments
Closed

Cannot use ::class with dynamic class name #7

ArpadGBondor opened this issue Feb 8, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@ArpadGBondor
Copy link

ArpadGBondor commented Feb 8, 2024

Describe the bug

We keep getting an error thrown from this package:
Cannot use ::class with dynamic class name

It is coming from here:
/nystudio107/craft-code-editor/src/autocompletes/SectionShorthandFieldsAutocomplete.php:167

I think it is this line in the current version:

Expected behaviour

I think something like this would solve it:
nystudio107/craft-twigfield@bff508e

Versions

  • Plugin version:
    "nystudio107/craft-seomatic": "3.4.68",
  • Craft version:
    "craftcms/cms": "3.8.5",
    PHP - 7.4.33
@khalwat
Copy link
Contributor

khalwat commented Mar 19, 2024

I'm sorry I somehow missed this issue, thanks for re-filing it under SEOmatic to get my attention.

@khalwat
Copy link
Contributor

khalwat commented Mar 19, 2024

Addressed via c8c04db

@khalwat khalwat closed this as completed Mar 19, 2024
@khalwat
Copy link
Contributor

khalwat commented Mar 19, 2024

Fixed in version 1.0.18 -> https://github.com/nystudio107/craft-code-editor/releases/tag/1.0.18

You can update via:

composer update nystudio107/craft-code-editor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants