You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The mtime param appended to seo images doesn't take into account changes to asset settings local focal point.
The mtime param is created in line 156 of src/helpers/imageTransform.php. It checks the "dateModified" on the asset. The problem is that "dateModified" only takes into account changes to the actual asset file, not the asset settings. "dateUpdated" checks the asset settings.
To reproduce
Steps to reproduce the behaviour:
Navigate to asset used as an seo image
Change the focal point of that image
Navigate to the page that asset appears in the head of
Check mtime
Expected behaviour
Asset focal point should update in seomatic image meta tags.
Screenshots
If applicable, add screenshots to help explain your problem.
Versions
Plugin version: 1.1.56
Craft version: 4.4.7.1
The text was updated successfully, but these errors were encountered:
Remove mtime param
This fixed the issue with assets seomatic images updating when focal point is changed, but I'm not sure if the mtime param was added to solve some other issue.
Check dateModified and dateUpdated and use the newest
This will ensure that changes to the asset file and asset settings are taken into account when adding the mtime param.
Describe the bug
The mtime param appended to seo images doesn't take into account changes to asset settings local focal point.
The mtime param is created in line 156 of src/helpers/imageTransform.php. It checks the "dateModified" on the asset. The problem is that "dateModified" only takes into account changes to the actual asset file, not the asset settings. "dateUpdated" checks the asset settings.
To reproduce
Steps to reproduce the behaviour:
Expected behaviour
Asset focal point should update in seomatic image meta tags.
Screenshots
If applicable, add screenshots to help explain your problem.
Versions
The text was updated successfully, but these errors were encountered: