Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy loading for each photo in NYTPhotoViewer #162

Open
jacks8x opened this issue Feb 25, 2016 · 3 comments
Open

Lazy loading for each photo in NYTPhotoViewer #162

jacks8x opened this issue Feb 25, 2016 · 3 comments

Comments

@jacks8x
Copy link

jacks8x commented Feb 25, 2016

I just see below approach to use NYTPhotoViewer, follow this approach I have to init photos array with image data first (image data is very big compare with it's path or it's name), so in case I have 10000 or more photos, my photos array will very large and it will maybe out of memory or the app willbe freeze. How can I resolve this problem.

NYTPhotosViewController *photosViewController = [[NYTPhotosViewController alloc] initWithPhotos:photos];
[self presentViewController:photosViewController animated:YES completion:nil];
@cdzombak cdzombak changed the title Lazy loading for each photo in NYTPhotoViewer? Lazy loading for each photo in NYTPhotoViewer Feb 29, 2016
@cdzombak
Copy link
Contributor

@jacks8x this is a good point; lazy loading isn't something that the library currently allows.

As far as I know it's not in our plan, but we'll leave this issue open as a reminder, and pull requests would be welcome for discussion (though note that any pull request for this should probably take #163 into account, too).

@kimar
Copy link
Contributor

kimar commented Mar 1, 2016

I had to implement a lazy loader incl. a way to maintain interaction while a hi-res version of an image is loading. A provisional PR is here -> #160

Although I'm sure this should also be part of the bigger picture aka #163

@SkylerSeamans
Copy link

SkylerSeamans commented Jul 28, 2017

I'm also seeing issues with this. When loading a large array of images, many of the images at the end of the array have timed out due to network saturation. Lazy loading for images is a pretty standard mobile paradigm and without support, I'll be looking for another library or writing my own ViewController to handle this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants