New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Unnecessary Body Close #183

Closed

marwan-at-work opened this issue Feb 8, 2019 · 0 comments

Contributor

marwan-at-work commented Feb 8, 2019

According to net/http documentation, the server never needs to close a body request, see
https://golang.org/src/net/http/request.go?s=5615:5823#L96

So this whole defer statement is unnecessary: https://github.com/NYTimes/gizmo/blob/master/server/simple_server.go#L107:L113

marwan-at-work mentioned this issue

Remove unnecessary body close #189

Merged

jprobinson closed this as completed in #189

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment