Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract App Engine From server/kit #185

Closed
marwan-at-work opened this issue Feb 8, 2019 · 1 comment · Fixed by #192
Closed

Extract App Engine From server/kit #185

marwan-at-work opened this issue Feb 8, 2019 · 1 comment · Fixed by #192

Comments

@marwan-at-work
Copy link
Contributor

The App Engine Set Up (such as tracing, metrics, and logging) does not have to be locked with server/kit, this way you can use it with the SimpleServer

@jprobinson
Copy link
Contributor

If the abstraction fits well with both servers, I'm down for doing this. If it ends up being a square peg/circle hole problem, it may be fine to just put similar hooks into the SimpleServer.

As most users of the SimpleServer are using Prometheus, we'll likely need to do some tests to see if the OpenCensus Prom exporters give the same functionality as we have now. From there, we'll need to look to add some small config option in each server to select/register the appropriate OC exporters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants