Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server.MonitorRPCRequest() does not write to the RPCAccessLog #36

Closed
labkode opened this issue Mar 19, 2016 · 1 comment
Closed

server.MonitorRPCRequest() does not write to the RPCAccessLog #36

labkode opened this issue Mar 19, 2016 · 1 comment

Comments

@labkode
Copy link

labkode commented Mar 19, 2016

Still playing with the RPC example I have discovered that the server.MonitorRPCRequest() does not write to the RPC log file.

Any hint about a possible solution ? Thx
@jprobinson
Copy link
Contributor

MonitorRPCRequest was creating a logrus.Entry, but it wasn't actually logging it. I've added a simple INFO level "access" message to make the library emit something: 970f99b

Another nice catch! RPCServer has needed some love.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jprobinson @labkode