Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2E tests for kyt #162

Closed
ccpricenytimes opened this issue Sep 15, 2016 · 4 comments
Closed

E2E tests for kyt #162

ccpricenytimes opened this issue Sep 15, 2016 · 4 comments
Assignees
@ccpricenytimes

Comments

@ccpricenytimes
Copy link
Contributor

After Jest is complete, we should revisit end to end testing.

Things we should test:

  1. Server is healthy after hot reloading
  2. Build commands create correct assets
  3. environment variables are respected
  4. setup creates correct environment with and without starter kyts
@tizmagik
Copy link
Contributor

Can we refactor the work you did in #90 ?

@ccpricenytimes
Copy link
Contributor Author

It's possible. Not sure how much would work in Travis.

@tizmagik
Copy link
Contributor

For Travis we could run the test in a working/temp directory, it should work fine. I believe CRA does similar: https://github.com/facebookincubator/create-react-app/blob/master/tasks/e2e.sh#L115

@tizmagik
Copy link
Contributor

Also maybe this codemod as mentioned here would be useful too!

@ccpricenytimes ccpricenytimes self-assigned this Oct 7, 2016
@ccpricenytimes ccpricenytimes mentioned this issue Oct 16, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ccpricenytimes ccpricenytimes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tizmagik @delambo @ccpricenytimes