More preparation for iOS videos integration #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| _videoNode.position = CGPointMake(scene.size.width / 2, scene.size.height / 2); | ||
| _videoNode.size = scene.size; | ||
| _videoNode.yScale = -1; | ||
| _videoNode.xScale = -1; |
There was a problem hiding this comment.
For this "child object" initialization, can you please mimic the "scoped object creation & configuration" patter used to create the skScene?
|
This looks good to me overall. I would only suggest that the |
|
LGTM, one question, does controlling the the |
That has never worked. The |
|
@jaredsinclair 👍 once merge conflict is resolved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary goal was to add
playandpausemethods to NYT360VideoViewController. This required some new methods and properties in other classes to make it work. I also cleaned up some files I encountered to make the method groupings and variable names easier to follow.