Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging will be broken by dart-lang/logging#71 #47

Closed
jamesderlin opened this issue Jan 16, 2020 · 1 comment
Closed

Logging will be broken by dart-lang/logging#71 #47

jamesderlin opened this issue Jan 16, 2020 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@jamesderlin
Copy link

I've recently made a change (dart-lang/logging#71) that affects the behavior of Logger.detached from package:logging. This change expected to be included in logging 0.11.4.

This change in behavior should not affect most packages, but it appears that it will break logging in the nyxx package.

The recommended fix is to set Logger.level and Logger.onRecord on the detached Logger itself instead of on Logger.root. (In general, libraries should leave responsibility for configuring Logger.root to the application.)

@jamesderlin jamesderlin changed the title Logging will be broken by https://github.com/dart-lang/logging/pull/71 Logging will be broken by dart-lang/logging#71 Jan 16, 2020
@l7ssha
Copy link
Member

l7ssha commented Jan 19, 2020

Thanks for notice, I'll target this in next release.

@l7ssha l7ssha mentioned this issue Mar 22, 2020
21 tasks
@l7ssha l7ssha added bug Something isn't working fixed labels Apr 3, 2020
@l7ssha l7ssha added this to the 1.0.0 milestone Apr 9, 2020
@l7ssha l7ssha closed this as completed Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants